Added regression test #4307
Closed
Added regression test #4307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Sep 9, 2025
|
|
||
| foreach ($children as $child) { | ||
| if ($child instanceof Operator) { | ||
| for(;$operators !== [] && end($operators)->priority() >= $child->priority();) { |
There was a problem hiding this comment.
The test isn't faithful enough because there are no changes in NodeScopeResolver. And the same fix I did for While_ also needs to be done for For_ and many others.
| $operands = []; | ||
| $operators = []; | ||
|
|
||
| for ($i = 0; $i < count($children); $i++) { |
There was a problem hiding this comment.
I don't think the type of outer loop matters. We don't need more than one test for the same change and reported bug in src/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cover phpstan/phpstan#13385 with different loop types